ShowPopupAsync will now correctly return once the popup is closed under heavy garbage collection#2756
Merged
TheCodeTraveler merged 4 commits intomainfrom Jun 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ShowPopupAsync would not return correctly under heavy garbage collection by updating the popup closing mechanism and adding tests to simulate GC pressure.
- Replaced the WeakEventManager based PopupClosed event with a standard event invocation.
- Introduced a new popup subclass (GarbageCollectionHeavySelfClosingPopup) to simulate heavy GC scenarios during popup closure.
- Updated tests to include explicit GC.Collect calls around CloseAsync to validate the fix.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs | Replaced weak event manager with a standard event for PopupClosed |
| src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs | Added GC.Collect calls and a new popup subclass for heavy GC testing |
| src/CommunityToolkit.Maui.UnitTests/Extensions/PopupExtensionsTests.cs | Added a test to verify that ShowPopupAsync returns the correct result under heavy GC |
| src/CommunityToolkit.Maui.UnitTests/BaseHandlerTest.cs | Registered the new GarbageCollectionHeavySelfClosingPopup service |
Comments suppressed due to low confidence (3)
src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs:65
- Replacing the WeakEventManager with a standard event might lead to memory retention if subscribers are not properly unsubscribed. Ensure that consumers of PopupClosed unsubscribe when appropriate.
public event EventHandler<IPopupResult>? PopupClosed;
src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs:558
- Consider adding a comment explaining the intent behind invoking GC.Collect here, to improve clarity for future maintainers of this test.
GC.Collect();
src/CommunityToolkit.Maui.UnitTests/Services/PopupServiceTests.cs:560
- Consider adding a comment explaining the intent behind invoking GC.Collect here, to improve clarity for future maintainers of this test.
GC.Collect();
Contributor
Author
|
This will likely conflict with #2749 but I am happy to deal with that |
Closed
2 tasks
TheCodeTraveler
approved these changes
Jun 20, 2025
Collaborator
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks Shaun! Good catch!
Contributor
Author
|
Full credit to @mfeingol for the investigation into this. It was easy once he worked out that it was garbage collection related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information